On Fri, Jan 26, 2024 at 11:43 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > On Fri, Jan 26, 2024 at 03:36:55PM +0100, Thomas Richard wrote: ... > It'd be super nice to have them the same. Passing in a "probe" flag > works but seems a little harder to read in cdns_pcie_host_setup() and > you have to keep track of what it means in the callers. FWIW, in another patch with a similar approach I found it (the approach) a bit ugly and unmaintainable. I would suggest properly refactoring to create 2+ functions and use as needed. -- With Best Regards, Andy Shevchenko