Re: [PATCH v2 01/15] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 01/15] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq()
From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Date: Fri, 26 Jan 2024 23:30:14 +0200
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>, Bartosz Golaszewski <brgl@xxxxxxxx>, Andy Shevchenko <andy@xxxxxxxxxx>, Tony Lindgren <tony@xxxxxxxxxxx>, Haojian Zhuang <haojian.zhuang@xxxxxxxxxx>, Vignesh R <vigneshr@xxxxxx>, Aaro Koskinen <aaro.koskinen@xxxxxx>, Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxx>, Peter Rosin <peda@xxxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Kishon Vijay Abraham I <kishon@xxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Tom Joseph <tjoseph@xxxxxxxxxxx>, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, linux-gpio@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-phy@xxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, gregory.clement@xxxxxxxxxxx, theo.lebrun@xxxxxxxxxxx, thomas.petazzoni@xxxxxxxxxxx, u-kumar1@xxxxxx
In-reply-to: <20240102-j7200-pcie-s2r-v2-1-8e4f7d228ec2@bootlin.com>
References: <20240102-j7200-pcie-s2r-v2-0-8e4f7d228ec2@bootlin.com> <20240102-j7200-pcie-s2r-v2-1-8e4f7d228ec2@bootlin.com>

On Fri, Jan 26, 2024 at 4:37 PM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
>
> Some IOs can be needed during suspend_noirq()/resume_noirq().
> So move suspend()/resume() to noirq.

On the first glance the code is okay, but I haven't tested it on the
platforms I have that use this chip.
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH v2 00/15] Add suspend to ram support for PCIe on J7200
  - From: Thomas Richard
- [PATCH v2 01/15] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq()
  - From: Thomas Richard

Prev by Date: Re: [PATCH v2 04/15] mux: add mux_chip_resume() function
Next by Date: Re: [PATCH v2 02/15] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq
Previous by thread: [PATCH v2 01/15] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq()
Next by thread: Re: [PATCH v2 01/15] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq()
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]