On 1/19/24 17:11, Andy Shevchenko wrote:
> On Fri, Jan 19, 2024 at 6:08 PM Thomas Richard
> <thomas.richard@xxxxxxxxxxx> wrote:
>> On 1/15/24 21:02, Andy Shevchenko wrote:
>>> On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
>>> <thomas.richard@xxxxxxxxxxx> wrote:
>
> ...
>
>>>> +static const struct dev_pm_ops pinctrl_single_pm_ops = {
>>>> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pinctrl_single_suspend_noirq,
>>>> + pinctrl_single_resume_noirq)
>>>> +};
>>>
>>> Use proper / modern macro.
>>
>> fixed, use DEFINE_NOIRQ_DEV_PM_OPS now
>
> ...
>
>>>> #endif
>>>
>>> Why ifdeferry is needed (esp. taking into account pm_ptr() use below)?
>>
>> We may have an "unused variable" warning for pinctrl_single_pm_ops if
>> CONFIG_PM is undefined (due to pm_ptr).
>
> This is coupled with the above. Fixing above will automatically make
> the right thing.
Yes you're right.
By the way I can use pm_sleep_ptr instead of pm_ptr.
--
Thomas Richard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
