RE: [RFC PATCH 0/3] lspci: Display cxl1.1 device link status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Martin Mareš <mj@xxxxxx>
> Sent: Wednesday, January 17, 2024 9:11 PM
> To: Kobayashi, Daisuke/小林 大介 <kobayashi.da-06@xxxxxxxxxxx>
> Cc: linux-pci@xxxxxxxxxxxxxxx; linux-cxl@xxxxxxxxxxxxxxx; Gotou, Yasunori/五島
> 康文 <y-goto@xxxxxxxxxxx>
> Subject: Re: [RFC PATCH 0/3] lspci: Display cxl1.1 device link status
> 
> Hello!
> 
> Sorry for the late reply, but these days I don't read linux-pci regularly. Please Cc
> me on all patches for the pciutils.
> 

I see. I'll include you in CC.

> Anyway...
> 
> I don't think this is the right approach. You poke things you shouldn't in user
> space, you also make some bold assumptions on endianity of the machine (you
> are using native C structs for data provided by the hardware).
> 
> This belongs to the kernel.

Thank you, Martin. I just want to say you made a good point. 
I totally missed that, so thanks for pointing it out.

> 
> 				Have a nice fortnight
> --
> Martin `MJ' Mareš                        <mj@xxxxxx>
> http://mj.ucw.cz/
> United Computer Wizards, Prague, Czech Republic, Europe, Earth, Universe




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux