On Mon, Jan 15, 2024 at 05:14:54PM +0100, Thomas Richard wrote:
> From: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>
> Move reset GPIO to device struct, so it can be used at suspend and
> resume stages.
s/Move/Add/ since we're not moving it from one struct to another. (In
subject also.)
s/device struct/struct j721e_pcie/ since "device struct" could also
refer to the "struct device", which is obviously not relevant here.
BTW, if you capitalize the PCI subject lines to match previous
history, it will save some work when applying this series.
Also rewrap commit logs to fill 75 columns and add blank lines between
paragraphs (noticed in patch 12/14).
> @@ -54,6 +54,7 @@ struct j721e_pcie {
> struct clk *refclk;
> u32 mode;
> u32 num_lanes;
> + struct gpio_desc *reset_gpio;
> void __iomem *user_cfg_base;
> void __iomem *intd_cfg_base;
> u32 linkdown_irq_regfield;
> @@ -359,7 +360,6 @@ static int j721e_pcie_probe(struct platform_device *pdev)
> struct j721e_pcie *pcie;
> struct cdns_pcie_rc *rc = NULL;
> struct cdns_pcie_ep *ep = NULL;
> - struct gpio_desc *gpiod;
> void __iomem *base;
> struct clk *clk;
> u32 num_lanes;
