Re: [PATCH 04/14] mux: mmio: Add resume support

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
>
> From: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>
> Implement resume support

Why?

...

> +#ifdef CONFIG_PM

No ifdeffery, use proper macros.

...

> +                       dev_err(dev, "control %u: error restoring mux: %d\n", i, ret);

Won't anything go wrong and spam the log buffer?

-- 
With Best Regards,
Andy Shevchenko