On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard <thomas.richard@xxxxxxxxxxx> wrote: > > Some IOs can be needed during suspend_noirq/resume_noirq. ->suspend_noirq() / ->resume_noirq() > So move suspend/resume callbacks to noirq. ... > -static DEFINE_SIMPLE_DEV_PM_OPS(pca953x_pm_ops, pca953x_suspend, pca953x_resume); > +static const struct dev_pm_ops pca953x_pm_ops = { > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pca953x_suspend_noirq, pca953x_resume_noirq) > +}; Please, use correct / modern macro. -- With Best Regards, Andy Shevchenko