Hi, The qcom,pcie.yaml containing all devices results in huge allOf: section with a lot of if:then: clauses making review and changes quite difficult. Split common parts into common schema and then move few devices to dedicated files, so that each file will be easier to review. I did not split/move all devices yet, so if this gets accepted I plan to send more patches. Best regards, Krzysztof --- Krzysztof Kozlowski (6): dt-bindings: PCI: qcom,pcie-sm8550: move SM8550 to dedicated schema dt-bindings: PCI: qcom,pcie-sm8450: move SM8450 to dedicated schema dt-bindings: PCI: qcom,pcie-sm8250: move SM8250 to dedicated schema dt-bindings: PCI: qcom,pcie-sm8150: move SM8150 to dedicated schema dt-bindings: PCI: qcom,pcie-sm8350: move SM8350 to dedicated schema dt-bindings: PCI: qcom,pcie-sc8280xp: move SC8280XP to dedicated schema .../devicetree/bindings/pci/qcom,pcie-common.yaml | 98 ++++++++ .../bindings/pci/qcom,pcie-sc8280xp.yaml | 180 ++++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8150.yaml | 157 ++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8250.yaml | 180 ++++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8350.yaml | 169 +++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8450.yaml | 215 +++++++++++++++++ .../devicetree/bindings/pci/qcom,pcie-sm8550.yaml | 171 +++++++++++++ .../devicetree/bindings/pci/qcom,pcie.yaml | 268 --------------------- 8 files changed, 1170 insertions(+), 268 deletions(-) --- base-commit: a0bf076e449e022944b440174491f5c583753d84 change-id: 20240108-dt-bindings-pci-qcom-split-624737f7ba67 Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>