On Wed, Dec 27, 2023 at 01:27:21PM -0500, Frank Li wrote: > snps,dw-pcie.yaml already have reg and reg-name information. Needn't > duplciate here. > > Add 'if' check for existed compatible string to restrict reg and reg-names. > This prepare to add new compatible string with difference reg-names sets. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> - Mani > --- > > Notes: > Change from v6 to v7 > - add Krzysztof's review tag > Change from v5 to v6 > - Add if check for existed compatible string > Change from v4 to v5 > - add Rob's Acked > Change from v1 to v4: > - new patch at v4 > > .../bindings/pci/fsl,imx6q-pcie.yaml | 30 ++++++++++++------- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > index 81bbb8728f0f9..eeca6b7b540f9 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > @@ -30,16 +30,6 @@ properties: > - fsl,imx8mm-pcie > - fsl,imx8mp-pcie > > - reg: > - items: > - - description: Data Bus Interface (DBI) registers. > - - description: PCIe configuration space region. > - > - reg-names: > - items: > - - const: dbi > - - const: config > - > clocks: > minItems: 3 > items: > @@ -90,6 +80,26 @@ required: > allOf: > - $ref: /schemas/pci/snps,dw-pcie.yaml# > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx6q-pcie > + - fsl,imx6sx-pcie > + - fsl,imx6qp-pcie > + - fsl,imx7d-pcie > + - fsl,imx8mq-pcie > + - fsl,imx8mm-pcie > + - fsl,imx8mp-pcie > + then: > + properties: > + reg: > + maxItems: 2 > + reg-names: > + items: > + - const: dbi > + - const: config > + > - if: > properties: > compatible: > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்
