On Fri, Apr 13, 2012 at 2:06 PM, Alex He <alex.he@xxxxxxx> wrote: > On Fri, Apr 13, 2012 at 10:35:34AM +0800, Yan, Zheng wrote: [snip] >> @@ -750,7 +750,8 @@ int pci_set_power_state(struct pci_dev *dev, pci_power_t state) >> if (state == PCI_D3hot && (dev->dev_flags & PCI_DEV_FLAGS_NO_D3)) >> return 0; >> >> - error = pci_raw_set_power_state(dev, state); >> + error = pci_raw_set_power_state(dev, state > PCI_D3hot ? >> + PCI_D3hot : state); > Do you want to set the pci device to D3hot if the state = D3Code through > PMCSR register? Yes. > I am agree if you realy want that but what is the meaninig > to distingulish D3cold with D3hot in this patch. We can't put the PCI device > through PMCSR register. Yes. We put PCI device into D3hot via PMCSR firstly, then we use ACPI _PS3 and _PR3 to put device into D3cold. Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html