On 1/4/2024 5:01 AM, Bartosz Golaszewski wrote: ... > diff --git a/drivers/pci/pcie/pwrseq/Kconfig b/drivers/pci/pcie/pwrseq/Kconfig > new file mode 100644 > index 000000000000..010e31f432c9 > --- /dev/null > +++ b/drivers/pci/pcie/pwrseq/Kconfig > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +menuconfig PCIE_PWRSEQ > + bool "PCIe Power Sequencing support" > + depends on PCIEPORTBUS > + help > + Say yes here to enable support for PCIe power sequencing > + drivers. Do we really need this configuration? I'm concerned about how do we let the end user know when this needs to be enabled. Speaking specifically about ath11k, almost all ath11k devices will not require this, but it then becomes a support issue that if you are using QCA6390 then you need to enable it. I see that in [RFC 8/9] PCI/pwrseq: add a pwrseq driver for QCA6390 there is an option to enable config PCIE_PWRSEQ_QCA6390 if PCIE_PWRSEQ is enabled, but you then have the menuconfig dilemma that you won't know that you need to enable PCIE_PWRSEQ if you are using QCA6390. Let me speak more to that in my review of that patch. /jeff
