On 25/12/2023 20:05, Krzysztof Kozlowski wrote: > On 24/12/2023 19:32, Frank Li wrote: >> There are clocks and clock-names restriction for difference compatible >> string. So needn't irrationality check again for clock's miniItems and >> maxItems. >> >> In fsl,imx6q-pcie-ep.yaml > > It is enough to say that bindings referencing this file already define > these constraints for each of the variants, so the if:else: is redundant. > > Two lines instead of ~20. > >> ... >> >> Acked-by: Rob Herring <robh@xxxxxxxxxx> > > How did you get it? Please point me to the lore link. This patch > appeared in v5 and there was no response from Rob, AFAIK. Ah, this patch was added at v4 and Rob acked that one. It's fine then, but you still could narrow the commit msg, if there is going to be a resend. Please write informative but concise messages. Best regards, Krzysztof
