Hello Manivannan, Serge,
> From: Manivannan Sadhasivam, Sent: Thursday, December 14, 2023 7:26 PM
>
> On Thu, Dec 14, 2023 at 12:40:13PM +0300, Serge Semin wrote:
> > Hi Yoshihiro
> >
> > On Thu, Dec 14, 2023 at 02:35:56AM +0000, Yoshihiro Shimoda wrote:
> > > Hello PCIe maintainers,
> > >
> > > > From: Yoshihiro Shimoda, Sent: Tuesday, November 14, 2023 2:55 PM
> > > >
> > > > This patch series tidies the code of PCIe dwc controllers and some
> > > > controllers up.
> > > >
> > > > Changes from v1:
> > > >
<snip URL>
> > > > - Based on the latest pci.git / next branch.
> > > > - Add a new patch to drop host prefix of members from dw_pcie_host_ops
> > > > in the patch 1/6.
> > > > - Add Reviewed-by tag in the patch 3/6.
> > > > - Drop unneeded local variable in the patch 4/6.
> > > > - Add new patches to resolve issues of clang warnings in the patch [56]/6.
> > > >
> > > > Justin Stitt (1):
> > > > PCI: iproc: fix -Wvoid-pointer-to-enum-cast warning
> > > >
> > > > Yoshihiro Shimoda (5):
> > > > PCI: dwc: Drop host prefix from struct dw_pcie_host_ops
> > > > PCI: dwc: Rename to .init in struct dw_pcie_ep_ops
> > > > PCI: dwc: Rename to .get_dbi_offset in struct dw_pcie_ep_ops
> > > > PCI: dwc: Add dw_pcie_ep_{read,write}_dbi[2] helpers
> > > > PCI: rcar-gen4: fix -Wvoid-pointer-to-enum-cast warning
> > >
> > > According to the patchwork [1], all patches have Reviewed-by tags.
> > > So, I think the patches are acceptable for upstream, but what do you think?
> > > I confirmed that the patches can be applied into the latest pci.git / next branch.
> >
> > What actually matters is to get all Manivannan or Jingoo or Gustavo
> > acks (the later two maintainers are unlikely to respond though) or any
> > higher maintainers approval. AFAICS this patch still hasn't got any
> > maintainers ack:
> >
<snip URLs>
> > I guess it's connected with a request to move the helpers to the
> > header file.
> >
>
> Yes. I recommended moving the helpers to header file to keep the consistency and
> there was no reply from Yoshihiro.
>
> Yoshihiro, should you have any objections, please counter in the patch thread
> 4/6. Otherwise, please implement the proposed change.
Thank you very much for your reply. I completely overlooked the Manivannan's reply in
the patch thread 4/6... I'll check it.
Best regards,
Yoshihiro Shimoda
> - Mani
>
> > -Serge(y)
> >
> > >
> > > [1]
> > >
> https://patchwork.kernel.org/project/linux-pci/list%25
> 2F%3Fseries%3D800901&data=05%7C02%7Cyoshihiro.shimoda.uh%40renesas.com%7C1b5becdb6547403a8f6108dbfc8f1e49%7C53d82571
> da1947e49cb4625a166a4a2a%7C0%7C0%7C638381463836835213%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLC
> JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=CzGLVT59C%2Bl4ZSKmYJmouu564pFXOuDbnUVKYQNWLhM%3D&reserved=0
> > >
> > > Best regards,
> > > Yoshihiro Shimoda
> > >
> > > > drivers/pci/controller/dwc/pci-dra7xx.c | 4 +-
> > > > drivers/pci/controller/dwc/pci-exynos.c | 2 +-
> > > > drivers/pci/controller/dwc/pci-imx6.c | 6 +-
> > > > drivers/pci/controller/dwc/pci-keystone.c | 8 +-
> > > > .../pci/controller/dwc/pci-layerscape-ep.c | 7 +-
> > > > drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
> > > > drivers/pci/controller/dwc/pci-meson.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-al.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-armada8k.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +-
> > > > drivers/pci/controller/dwc/pcie-bt1.c | 4 +-
> > > > .../pci/controller/dwc/pcie-designware-ep.c | 249 ++++++++++--------
> > > > .../pci/controller/dwc/pcie-designware-host.c | 30 +--
> > > > .../pci/controller/dwc/pcie-designware-plat.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-designware.h | 12 +-
> > > > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-fu740.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-histb.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-keembay.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-kirin.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-qcom.c | 6 +-
> > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +-
> > > > drivers/pci/controller/dwc/pcie-spear13xx.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-uniphier.c | 2 +-
> > > > drivers/pci/controller/dwc/pcie-visconti.c | 2 +-
> > > > drivers/pci/controller/pcie-iproc-platform.c | 2 +-
> > > > 30 files changed, 203 insertions(+), 177 deletions(-)
> > > >
> > > > --
> > > > 2.34.1
> > >
> > >
> >
>
> --
> மணிவண்ணன் சதாசிவம்
