Drop period at the end of subject line. It only adds the possibility
of unnecessary line wrapping in git log.
On Wed, Dec 13, 2023 at 05:28:47PM +0800, Sherry Sun wrote:
> Add pci host wakeup feature for imx platforms.
s/pci/PCI/
s/imx/i.MX/ (based on how nxp.com web pages refer to it)
> Example of configuring the corresponding dts property under the PCI
> node:
> wake-gpios = <&gpio5 21 GPIO_ACTIVE_LOW>;
Add newline between paragraphs or wrap into a single paragraph.
> + /* host wakeup support */
> + imx6_pcie->host_wake_irq = -1;
AFAIK, 0 is an invalid IRQ value. So why not drop this assignment
since imx6_pcie->host_wake_irq is 0 by default since it was allocated
with devm_kzalloc(), and test like this elsewhere:
if (imx6_pcie->host_wake_irq) {
enable_irq_wake(imx6_pcie->host_wake_irq)
> + host_wake_gpio = devm_gpiod_get_optional(dev, "wake", GPIOD_IN);
> + if (IS_ERR(host_wake_gpio))
> + return PTR_ERR(host_wake_gpio);
> +
> + if (host_wake_gpio != NULL) {
if (host_wake_gpio)
Bjorn
