On Tue, Dec 12, 2023 at 10:46:36PM -0500, Ethan Zhao wrote: > move pci_dev_is_disconnected() from driver/pci/pci.h to public > include/linux/pci.h for other driver's reference. > no function change. That's merely a prose description of the code. A reader can already see from the code what it's doing. You need to explain the *reason* for the change instead. E.g.: "Make pci_dev_is_disconnected() public so that it can be called from $DRIVER to speed up hot removal handling which may otherwise take seconds because of $REASONS." Thanks, Lukas