On Wed, Nov 22, 2023 at 03:33:04PM +0900, Damien Le Moal wrote: > On 11/22/23 15:23, Christoph Hellwig wrote: > > On Wed, Nov 22, 2023 at 03:22:54PM +0900, Damien Le Moal wrote: > >> I did not want to go as far as changing all drivers everywhere and limited the > >> series to drivers/pci. We could do a coccinel script for everything else. > > > > Yes. This is actually even trivial enough for sed :) > > Surprisingly, only 44 files use PCI_IRQ_LEGACY. Let me see how a patch look > with the change. As mentioned in reply 1 I think this is perfect for a scripted run after -rc1. I'm actually surprised PCI_IRQ_LEGACY is used even 44 times. There is really no point in using the APIs based on PCI_IRQ_ for legacy irqs, and the case where it is just supposed as a fallback are covered by PCI_IRQ_ALL_TYPES.