On Tue, Nov 21, 2023 at 05:02:22PM -0800, Daniel Stodden wrote: > > I apologize for the confusion. > > Re-starting this thread wasn’t much about adding more reviewer names. > > What I meant was what came out of his review: > > diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c > index 073d0f7f5e43..b1990bde688c 100644 > --- a/drivers/pci/switch/switchtec.c > +++ b/drivers/pci/switch/switchtec.c > @@ -1387,6 +1387,7 @@ static struct switchtec_dev *stdev_create(struct pci_dev *pdev) > > err_put: > put_device(&stdev->dev); > + pci_dev_put(stdev->pdev); > return ERR_PTR(rc); > } > > > I probably should not’ have put that patch fragment at the far end of my email, past the signature. > > If you prefer a v4, I’ll make a v4. Yeah, just post a v4 if you don't mind. Another version is free, and then there's no confusion about what you intend :)