On Tue, Nov 21, 2023 at 04:02:12PM -0800, Daniel Stodden wrote: > > On Nov 21, 2023, at 3:58 PM, Daniel Stodden <dns@xxxxxxxxxx> wrote: > > > > + put_device(&stdev->pdev); > > That was just a sketch. Actuall pci_dev_put. Can you clarify what I should do with this? The current commit log reads like this: A PCI device hot removal may occur while stdev->cdev is held open. The call to stdev_release() then happens during close or exit, at a point way past switchtec_pci_remove(). Otherwise the last ref would vanish with the trailing put_device(), just before return. Are you saying it needs a change? Bjorn
