On Wed, Nov 22, 2023 at 12:25:48AM +0000, Dmitry Safonov wrote: > On 11/22/23 00:19, Bjorn Helgaas wrote: > > On Tue, Nov 21, 2023 at 03:58:22PM -0800, Daniel Stodden wrote: > >>> On Nov 21, 2023, at 10:40 AM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > >>> On Tue, Nov 21, 2023 at 10:23:51AM -0800, Daniel Stodden wrote: > >>>>> On Nov 20, 2023, at 1:25 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > >>>>> On Mon, Nov 13, 2023 at 01:21:50PM -0800, Daniel Stodden wrote: > >>>>>> A pci device hot removal may occur while stdev->cdev is held open. The > >>>>>> call to stdev_release is then delivered during close or exit, at a > >>>>>> point way past switchtec_pci_remove. Otherwise the last ref would > >>>>>> vanish with the trailing put_device, just before return. > It's fine to drop my SoB. With the fixup above, > > Reviewed-by: Dmitry Safonov <dima@xxxxxxxxxx> Done, thanks!