On Tue, Nov 21, 2023 at 10:23:51AM -0800, Daniel Stodden wrote: > > On Nov 20, 2023, at 1:25 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > On Mon, Nov 13, 2023 at 01:21:50PM -0800, Daniel Stodden wrote: > >> A pci device hot removal may occur while stdev->cdev is held open. The > >> call to stdev_release is then delivered during close or exit, at a > >> point way past switchtec_pci_remove. Otherwise the last ref would > >> vanish with the trailing put_device, just before return. > >> > >> At that later point in time, the device layer has alreay removed > >> stdev->mrpc_mmio map. Also, the stdev->pdev reference was not a > > > > I guess this should say the "stdev->mmio_mrpc" (not "mrpc_mmio")? > > Eww. My fault. Could you still correct that? Yep, I speculatively made that change already, so thanks for confirming it :) https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=switchtec&id=f9724598e29d Bjorn
