On Tue, 2023-11-21 at 08:29 +0100, Arnd Bergmann wrote: > On Mon, Nov 20, 2023, at 22:59, Philipp Stanner wrote: > > The pcim_*() functions in lib/devres.c are guarded by an #ifdef > > CONFIG_PCI and, thus, don't belong to this file. They are only ever > > used > > for pci and not generic infrastructure. > > > > Move all pcim_*() functions in lib/devres.c to drivers/pci/devres.c > > > > Suggested-by: Danilo Krummrich <dakr@xxxxxxxxxx> > > Signed-off-by: Philipp Stanner <pstanner@xxxxxxxxxx> > > --- > > drivers/pci/Makefile | 2 +- > > drivers/pci/devres.c | 207 > > ++++++++++++++++++++++++++++++++++++++++++ > > lib/devres.c | 208 +-------------------------------------- > > ---- > > Since you are moving the pci_iomap() code into drivers/pci/ already, > I'd suggest merging this one into the same file and keep the two > halves of this interface together. I'd argue that they are as much together as they were before: Previously: * PCI-IOMAP-code in folder lib/ in its own file (pci_iomap.c) * PCI-Devres-code in folder lib/ in a distinct file (devres.c) Now: * PCI-IOMAP-code in folder drivers/pci/ in its own file (iomap.c) * PCI-Devres-code in folder drivers/pci/ in its own file (devres.c) Or am I misunderstanding something? P. > > Arnd >
