Hello Bjorn, On Mon, Nov 20, 2023 at 03:30:07PM -0600, Bjorn Helgaas wrote: > On Mon, Nov 20, 2023 at 10:22:24PM +0100, Uwe Kleine-König wrote: > > On Fri, Oct 20, 2023 at 11:21:07AM +0200, Uwe Kleine-König wrote: > > > The .remove() callback for a platform driver returns an int which makes > > > many driver authors wrongly assume it's possible to do error handling by > > > returning an error code. However the value returned is (mostly) ignored > > > and this typically results in resource leaks. To improve here there is a > > > quest to make the remove callback return void. In the first step of this > > > quest all drivers are converted to .remove_new() which already returns > > > void. > > > > > > pci_host_common_remove() returned zero unconditionally. With that > > > converted to return void instead, the generic pci host driver can be > > > switched to .remove_new trivially. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > who feels responsible to apply this patch? > > If you're ready to rename .remove_new() back to .remove(), you can > include this as part of that series with my ack: > > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Or we can take it via the PCI tree for v6.8. The idea is that all drivers are converted to .remove_new() before changing .remove() to return void. This way the commit changing struct platform_driver doesn't has to touch the 1000+ platform drivers. So if you take this patch via pci in the next merge window, that would be good. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
