RE: [PATCH 1/3] PCI: dwc: Rename to .init in struct dw_pcie_ep_ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Serge,

> From: Serge Semin, Sent: Monday, November 13, 2023 7:15 PM
> 
> Hi Yoshihiro.
> 
> On Mon, Nov 13, 2023 at 10:32:58AM +0900, Yoshihiro Shimoda wrote:
> > Since the name of dw_pcie_ep_ops indicates that it's for ep obviously,
> > rename a member .ep_init to .init.
> 
> Thanks for the series. This change particularly looks good. But since
> you are fixing the redundant prefixes anyway, could you also fix the
> dw_pcie_host_ops structure too (drop host_ prefixes from the
> .host_init() and .host_deinit() fields)? The change was discussed a
> while ago here
> https://lore.kernel.org/linux-pci/20230802104049.GB57374@thinkpad/
> 
> It's better to be done in the framework of a separate patch released
> within this series.

Thank you for reminding me about the discussion. I'll add such a patch in v2.

Best regards,
Yoshihiro Shimoda

> -Serge(y)
> 
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> >  drivers/pci/controller/dwc/pci-dra7xx.c           | 2 +-
> >  drivers/pci/controller/dwc/pci-imx6.c             | 2 +-
> >  drivers/pci/controller/dwc/pci-keystone.c         | 2 +-
> >  drivers/pci/controller/dwc/pci-layerscape-ep.c    | 2 +-
> >  drivers/pci/controller/dwc/pcie-artpec6.c         | 2 +-
> >  drivers/pci/controller/dwc/pcie-designware-ep.c   | 4 ++--
> >  drivers/pci/controller/dwc/pcie-designware-plat.c | 2 +-
> >  drivers/pci/controller/dwc/pcie-designware.h      | 2 +-
> >  drivers/pci/controller/dwc/pcie-keembay.c         | 2 +-
> >  drivers/pci/controller/dwc/pcie-qcom-ep.c         | 2 +-
> >  drivers/pci/controller/dwc/pcie-rcar-gen4.c       | 2 +-
> >  drivers/pci/controller/dwc/pcie-uniphier-ep.c     | 2 +-
> >  12 files changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> > index b445ffe95e3f..f9182cd6fe67 100644
> > --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> > @@ -436,7 +436,7 @@ dra7xx_pcie_get_features(struct dw_pcie_ep *ep)
> >  }
> >
> >  static const struct dw_pcie_ep_ops pcie_ep_ops = {
> > -	.ep_init = dra7xx_pcie_ep_init,
> > +	.init = dra7xx_pcie_ep_init,
> >  	.raise_irq = dra7xx_pcie_raise_irq,
> >  	.get_features = dra7xx_pcie_get_features,
> >  };
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> > index 74703362aeec..737d4d90fef2 100644
> > --- a/drivers/pci/controller/dwc/pci-imx6.c
> > +++ b/drivers/pci/controller/dwc/pci-imx6.c
> > @@ -1093,7 +1093,7 @@ imx6_pcie_ep_get_features(struct dw_pcie_ep *ep)
> >  }
> >
> >  static const struct dw_pcie_ep_ops pcie_ep_ops = {
> > -	.ep_init = imx6_pcie_ep_init,
> > +	.init = imx6_pcie_ep_init,
> >  	.raise_irq = imx6_pcie_ep_raise_irq,
> >  	.get_features = imx6_pcie_ep_get_features,
> >  };
> > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
> > index 0def919f89fa..655c7307eb88 100644
> > --- a/drivers/pci/controller/dwc/pci-keystone.c
> > +++ b/drivers/pci/controller/dwc/pci-keystone.c
> > @@ -944,7 +944,7 @@ ks_pcie_am654_get_features(struct dw_pcie_ep *ep)
> >  }
> >
> >  static const struct dw_pcie_ep_ops ks_pcie_am654_ep_ops = {
> > -	.ep_init = ks_pcie_am654_ep_init,
> > +	.init = ks_pcie_am654_ep_init,
> >  	.raise_irq = ks_pcie_am654_raise_irq,
> >  	.get_features = &ks_pcie_am654_get_features,
> >  };
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > index 3d3c50ef4b6f..4e4b687ef508 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > @@ -195,7 +195,7 @@ static unsigned int ls_pcie_ep_func_conf_select(struct dw_pcie_ep *ep,
> >  }
> >
> >  static const struct dw_pcie_ep_ops ls_pcie_ep_ops = {
> > -	.ep_init = ls_pcie_ep_init,
> > +	.init = ls_pcie_ep_init,
> >  	.raise_irq = ls_pcie_ep_raise_irq,
> >  	.get_features = ls_pcie_ep_get_features,
> >  	.func_conf_select = ls_pcie_ep_func_conf_select,
> > diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c
> > index 9b572a2b2c9a..27ff425c0698 100644
> > --- a/drivers/pci/controller/dwc/pcie-artpec6.c
> > +++ b/drivers/pci/controller/dwc/pcie-artpec6.c
> > @@ -370,7 +370,7 @@ static int artpec6_pcie_raise_irq(struct dw_pcie_ep *ep, u8 func_no,
> >  }
> >
> >  static const struct dw_pcie_ep_ops pcie_ep_ops = {
> > -	.ep_init = artpec6_pcie_ep_init,
> > +	.init = artpec6_pcie_ep_init,
> >  	.raise_irq = artpec6_pcie_raise_irq,
> >  };
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> > index f6207989fc6a..ea99a97ce504 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> > @@ -794,8 +794,8 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
> >  		list_add_tail(&ep_func->list, &ep->func_list);
> >  	}
> >
> > -	if (ep->ops->ep_init)
> > -		ep->ops->ep_init(ep);
> > +	if (ep->ops->init)
> > +		ep->ops->init(ep);
> >
> >  	ret = pci_epc_mem_init(epc, ep->phys_base, ep->addr_size,
> >  			       ep->page_size);
> > diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c
> > index b625841e98aa..97088b7663e0 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware-plat.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c
> > @@ -74,7 +74,7 @@ dw_plat_pcie_get_features(struct dw_pcie_ep *ep)
> >  }
> >
> >  static const struct dw_pcie_ep_ops pcie_ep_ops = {
> > -	.ep_init = dw_plat_pcie_ep_init,
> > +	.init = dw_plat_pcie_ep_init,
> >  	.raise_irq = dw_plat_pcie_ep_raise_irq,
> >  	.get_features = dw_plat_pcie_get_features,
> >  };
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> > index 55ff76e3d384..cad0e4c24e11 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.h
> > +++ b/drivers/pci/controller/dwc/pcie-designware.h
> > @@ -332,7 +332,7 @@ struct dw_pcie_rp {
> >
> >  struct dw_pcie_ep_ops {
> >  	void	(*pre_init)(struct dw_pcie_ep *ep);
> > -	void	(*ep_init)(struct dw_pcie_ep *ep);
> > +	void	(*init)(struct dw_pcie_ep *ep);
> >  	void	(*deinit)(struct dw_pcie_ep *ep);
> >  	int	(*raise_irq)(struct dw_pcie_ep *ep, u8 func_no,
> >  			     enum pci_epc_irq_type type, u16 interrupt_num);
> > diff --git a/drivers/pci/controller/dwc/pcie-keembay.c b/drivers/pci/controller/dwc/pcie-keembay.c
> > index 289bff99d762..3c38e047d5ed 100644
> > --- a/drivers/pci/controller/dwc/pcie-keembay.c
> > +++ b/drivers/pci/controller/dwc/pcie-keembay.c
> > @@ -325,7 +325,7 @@ keembay_pcie_get_features(struct dw_pcie_ep *ep)
> >  }
> >
> >  static const struct dw_pcie_ep_ops keembay_pcie_ep_ops = {
> > -	.ep_init	= keembay_pcie_ep_init,
> > +	.init	= keembay_pcie_ep_init,
> >  	.raise_irq	= keembay_pcie_ep_raise_irq,
> >  	.get_features	= keembay_pcie_get_features,
> >  };
> > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> > index 9e58f055199a..2b6f7c144c61 100644
> > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
> > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> > @@ -796,7 +796,7 @@ static void qcom_pcie_ep_init(struct dw_pcie_ep *ep)
> >  }
> >
> >  static const struct dw_pcie_ep_ops pci_ep_ops = {
> > -	.ep_init = qcom_pcie_ep_init,
> > +	.init = qcom_pcie_ep_init,
> >  	.raise_irq = qcom_pcie_ep_raise_irq,
> >  	.get_features = qcom_pcie_epc_get_features,
> >  };
> > diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> > index 3bc45e513b3d..2b7e0f213fb2 100644
> > --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> > +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> > @@ -408,7 +408,7 @@ static unsigned int rcar_gen4_pcie_ep_get_dbi2_offset(struct dw_pcie_ep *ep,
> >
> >  static const struct dw_pcie_ep_ops pcie_ep_ops = {
> >  	.pre_init = rcar_gen4_pcie_ep_pre_init,
> > -	.ep_init = rcar_gen4_pcie_ep_init,
> > +	.init = rcar_gen4_pcie_ep_init,
> >  	.deinit = rcar_gen4_pcie_ep_deinit,
> >  	.raise_irq = rcar_gen4_pcie_ep_raise_irq,
> >  	.get_features = rcar_gen4_pcie_ep_get_features,
> > diff --git a/drivers/pci/controller/dwc/pcie-uniphier-ep.c b/drivers/pci/controller/dwc/pcie-uniphier-ep.c
> > index cba3c88fcf39..40bd468f7e11 100644
> > --- a/drivers/pci/controller/dwc/pcie-uniphier-ep.c
> > +++ b/drivers/pci/controller/dwc/pcie-uniphier-ep.c
> > @@ -284,7 +284,7 @@ uniphier_pcie_get_features(struct dw_pcie_ep *ep)
> >  }
> >
> >  static const struct dw_pcie_ep_ops uniphier_pcie_ep_ops = {
> > -	.ep_init = uniphier_pcie_ep_init,
> > +	.init = uniphier_pcie_ep_init,
> >  	.raise_irq = uniphier_pcie_ep_raise_irq,
> >  	.get_features = uniphier_pcie_get_features,
> >  };
> > --
> > 2.34.1
> >




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux