On Fri, 3 Nov 2023, Mario Limonciello wrote: > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > using dev_is_removable() to be able to detect USB4 devices as well. Please extend this with more details. I had to lookup the TBT change to be able to make any guess why you're doing this (and it's still a guess at best). -- i. > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> > --- > drivers/gpu/drm/nouveau/nouveau_vga.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c > index f8bf0ec26844..14215b7ca187 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_vga.c > +++ b/drivers/gpu/drm/nouveau/nouveau_vga.c > @@ -94,8 +94,8 @@ nouveau_vga_init(struct nouveau_drm *drm) > > vga_client_register(pdev, nouveau_vga_set_decode); > > - /* don't register Thunderbolt eGPU with vga_switcheroo */ > - if (pci_is_thunderbolt_attached(pdev)) > + /* don't register USB4/Thunderbolt eGPU with vga_switcheroo */ > + if (dev_is_removable(&pdev->dev)) > return; > > vga_switcheroo_register_client(pdev, &nouveau_switcheroo_ops, runtime); > @@ -118,7 +118,7 @@ nouveau_vga_fini(struct nouveau_drm *drm) > > vga_client_unregister(pdev); > > - if (pci_is_thunderbolt_attached(pdev)) > + if (dev_is_removable(&pdev->dev)) > return; > > vga_switcheroo_unregister_client(pdev); >
