Re: [PATCH v9 01/20] dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


That is correct, I tested the entire series against Linux 6.6-rc7 and confirmed that pcie/nvme/usb work on the VisionFive2 device. I was unable to test the Microchip side of the equation. I will be more clear as to what I verified if I comment in the future.

John Clark

On 10/25/23 6:41 AM, Krzysztof Kozlowski wrote:
On 25/10/2023 12:28, Conor Dooley wrote:
Hi John,

On Mon, Oct 23, 2023 at 11:09:50PM -0400, John Clark wrote:
On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
On 20/10/2023 12:43, Minda Chen wrote:
Add PLDA XpressRICH PCIe host common properties dt-binding doc.
Microchip PolarFire PCIe host using PLDA IP.
Move common properties from Microchip PolarFire PCIe host
to PLDA files.

Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
Reviewed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
   .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
   .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++
Where was this patch reviewed?

Best regards,

This Conor's review tag. v2 :
This is Rob's review tag v3:
Tested-by: John Clark <inindev@xxxxxxxxx>:
I suspect you don't mean that you tested this individual dt-binding, but
rather that you tested the whole series. If so, you should probably
provide this tested-by against the cover-letter instead of this bindings
Yeah, otherwise I would like to hear how do you test bindings (other
than dt_binding_check which is something similar to testing as compiling

Best regards,

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux