Re: [PATCH v25 00/15] PCI: dwc: rcar-gen4: Add R-Car Gen4 PCIe support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 18, 2023 at 05:56:16PM +0900, Yoshihiro Shimoda wrote:
> Add R-Car S4-8 (R-Car Gen4) PCIe controller for both host and endpoint modes.
> To support them, modify PCIe DesignWare common codes.
> 
> Changes from v24:
> https://lore.kernel.org/linux-pci/20231011071423.249458-1-yoshihiro.shimoda.uh@xxxxxxxxxxx/
>  - Based on the latest pci.git / next branch.
>  - Reordering the patches. (This is suggested by Bjorn.)
>  - Drop "PCI: dwc: Disable two BARs to avoid unnecessary memory assignment"
>    because break other platforms.

Does R-Car Gen4 still work without this patch?

The previous commit log said host mode didn't work:

  PCI: dwc: Disable two BARs to avoid unnecessary memory assignment

  According to the section 3.5.7.2 "RC Mode" in DWC PCIe Dual Mode
  Rev.5.20a, we should disable two BARs to avoid unnecessary memory
  assignment during device enumeration. Otherwise, Renesas R-Car Gen4
  PCIe controllers cannot work correctly in host mode.

(from
https://lore.kernel.org/r/20231011071423.249458-9-yoshihiro.shimoda.uh@xxxxxxxxxxx)

I don't think we want to merge the driver unless it actually works.

Bjorn



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux