This an alternative approach to the patch in: https://lore.kernel.org/linux-pci/20231010204436.1000644-7-helgaas@xxxxxxxxxx/ It adds names to all the reason literals too (which makes it incompatible with FIELD_GET() for the reason and ext_reason). When the reasons are named instead of literals, it's very easy to understand the code just by reading it (no need to lookup the meaning of those numbers from spec or otherwise). Also 0xfff4 the other patch missed is converted here. Just let me know if I should, for example, base the additional changes on top of that other change. Ilpo Järvinen (2): PCI: Add PCI_EXP_DPC_* field details PCI/DPC: Use defines with register fields drivers/pci/pcie/dpc.c | 39 +++++++++++++++++++++-------------- include/uapi/linux/pci_regs.h | 7 +++++++ 2 files changed, 31 insertions(+), 15 deletions(-) -- 2.30.2
