Hi Angelo, Thanks for your comment. On Tue, 2023-10-10 at 11:45 +0200, AngeloGioacchino Del Regno wrote: > Il 09/10/23 10:49, Jian Yang ha scritto: > > From: "jian.yang" <jian.yang@xxxxxxxxxxxx> > > > > Add new properties to support control power supplies and reset pin > > of > > a downstream component. > > > > Signed-off-by: jian.yang <jian.yang@xxxxxxxxxxxx> > > --- > > .../bindings/pci/mediatek-pcie-gen3.yaml | 30 > > +++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml > > index 7e8c7a2a5f9b..eb4ad98549d1 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -84,6 +84,26 @@ properties: > > items: > > enum: [ phy, mac ] > > > > + pcie1v8-supply: > > There are another two controllers having such regulators and they all > have the > same name for those supplies; Can you please change the names to be > consistent > with the other controllers? > > vpcie1v8 > vpcie3v3 > vpcie12v > I will rename them in next patch version. > Regards, > Angelo > > Best regards, Jian Yang