On Tue, 10 Oct 2023 15:44:27 -0500 Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Use FIELD_GET() to remove dependences on the field position, i.e., the > shift value. No functional change intended. > > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> It's a little unfortunate that some of the masks are called *_MASK and others are not (e.g. PCI_RBAR_CTRL_BAR_SIZE which is a mask). but given they are in include/uapi not sure we can tidy that up unless we add more defines that stick to consistent naming... Otherwise very nice. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
