On Wed, Oct 11, 2023 at 12:54:59AM +0000, Yoshihiro Shimoda wrote: > Hello Manivannan, > > > From: Manivannan Sadhasivam, Sent: Tuesday, October 10, 2023 8:25 PM > > To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > Cc: lpieralisi@xxxxxxxxxx; kw@xxxxxxxxx; robh@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > > conor+dt@xxxxxxxxxx; jingoohan1@xxxxxxxxx; gustavo.pimentel@xxxxxxxxxxxx; marek.vasut+renesas@xxxxxxxxx; > > linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; Geert Uytterhoeven > > <geert+renesas@xxxxxxxxx>; Serge Semin <fancer.lancer@xxxxxxxxx>; Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Subject: Re: [PATCH v21 10/16] dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Host > > > > On Fri, Sep 22, 2023 at 03:53:25PM +0900, Yoshihiro Shimoda wrote: > > > Document bindings for Renesas R-Car Gen4 and R-Car S4-8 (R8A779F0) > > > PCIe host module. > > > > > > Link: > <snip URL> > > > Link: > <snip URL> > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > > Signed-off-by: Krzysztof Wilczyński <kwilczynski@xxxxxxxxxx> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > > Reviewed-by: Serge Semin <fancer.lancer@xxxxxxxxx> > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > --- > > > .../bindings/pci/rcar-gen4-pci-host.yaml | 127 ++++++++++++++++++ > > > 1 file changed, 127 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > > new file mode 100644 > > > index 000000000000..ffb34339b637 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml [...] > > > + #interrupt-cells = <1>; > > > + interrupt-map-mask = <0 0 0 7>; > > > + interrupt-map = <0 0 0 1 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>, > > > + <0 0 0 2 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>, > > > + <0 0 0 3 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>, > > > + <0 0 0 4 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>; > > > > I believe these are for legacy INTx interrupts. But you are using the same IRQ > > number used for MSI above. Can you clarify? > > On the SoC (R-Car S4-8), the same IRQ number is used for both MSI and legacy INTx > interrupts... > Ok. This seems wierd, but fine with me. - Mani -- மணிவண்ணன் சதாசிவம்
