On Thu, Sep 21, 2023 at 03:55:29PM +1000, Alistair Francis wrote: > DOE r1.1 replaced all occurrences of "protocol" with the term "feature" > or "Data Object Type". > > PCIe r6.1 (which was published July 24) incorporated that change. > > This patch renames the existing terms protocol with feature. Imperative mood is generally preferred instead of "This patch", i.e.: "Rename the exising..." Could you also rename PCI_DOE_DATA_OBJECT_DISC_RSP_3_PROTOCOL to PCI_DOE_DATA_OBJECT_DISC_RSP_3_TYPE (per PCIe r6.1 Table 6-31, both in drivers/pci/doe.c and include/uapi/linux/pci_regs.h). Likewise PCI_DOE_PROTOCOL_DISCOVERY to PCI_DOE_FEATURE_DISCOVERY (per PCIe r6.1 sec 6.30.1.1, only in drivers/pci/doe.c)? With that addressed, Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx> Thanks! Lukas
