On Thu, Sep 28, 2023 at 04:27:57PM -0500, Bjorn Helgaas wrote: > On Thu, Sep 28, 2023 at 08:48:08PM +0200, Manivannan Sadhasivam wrote: > > On Wed, Sep 27, 2023 at 12:55:42PM -0500, Bjorn Helgaas wrote: > > > On Wed, Sep 27, 2023 at 05:46:02PM +0200, Manivannan Sadhasivam wrote: > > > > Instead of hardcoding the link speed in MBps, let's make use of the > > > > existing PCIE_SPEED2MBS_ENC() macro that does the encoding of the > > > > link speed for us. Also, let's Wrap it with QCOM_PCIE_LINK_SPEED_TO_BW() > > > > macro to do the conversion to ICC speed. > > > > > - ret = icc_set_bw(pcie_ep->icc_mem, 0, MBps_to_icc(PCIE_GEN1_BW_MBPS)); > > > > + ret = icc_set_bw(pcie_ep->icc_mem, 0, QCOM_PCIE_LINK_SPEED_TO_BW(1)); > > > > > > "1" is not very informative here. Maybe PCIE_SPEED_2_5GT? (I didn't > > > completely verify that this is equivalent.) > > > > No. PCIE_SPEED_2_5GT is defined as 0x14 in pci.h. And I do not want to add a > > macro for just "1" here. > > Is there no other existing macro that contains the 2.5GT/s hint? I couldn't find any :/ Adding a new macro would collide with the existing one IMO. - Mani -- மணிவண்ணன் சதாசிவம்
