On Thu, Sep 21, 2023 at 10:09:16PM +0100, Cameron Williams wrote: > Add device IDs for PCI/PCIe serial cards manufactured by > Brainboxes (IS/IX/UC/UP/PX). > Apologies if this file isn't strictly for your tree. All trees > I am sending this patch series to use these PCI IDs, I was unsure > if this was the correct way to go about it, and better safe than > sorry. Thank you for understanding and please disregard if > its not required. >From the top of the file: * Do not add new entries to this file unless the definitions * are shared between multiple drivers. I can't tell whether that applies here since I haven't seen the other patches. If they're only used in one file, you can add the #define to that file or use the bare hex values. This reduces merge conflicts in pci_ids.h when backporting things. Also it looks like there's a mix of tab vs space indentation below. They should all be tabs before the device ID and it looks like a single space before the comment. > +#define PCI_DEVICE_ID_INTASHIELD_UC246 0x0aa1 /* Revision 2*/ > +#define PCI_DEVICE_ID_INTASHIELD_UC246R3 0x0aa2 /* Revision 3 */ Comment indentation error. > +#define PCI_DEVICE_ID_INTASHIELD_PX803R3 0x401e /* Revision 3 */ > +#define PCI_DEVICE_ID_INTASHIELD_PX475LPT 0x401f /* LPT port */ Indentation error.
