On Sat, Sep 16, 2023 at 01:11:29AM +0100, Conor Dooley wrote: > On Fri, Sep 15, 2023 at 06:22:32PM +0800, Minda Chen wrote: > > For PolarFire implements non-PLDA local interrupt events, most of > > event interrupt process codes can not be re-used. PLDA implements > > new codes and IRQ domain ops like PolarFire. > > > > plda_get_events() adds a new IRQ num to event num mapping codes for > > PLDA local event except DMA engine interrupt events. The DMA engine > > interrupt events are implemented by vendors. > > > > Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> > > Perhaps not important as they will go away in the next patch, but for > this patch the riscv patchwork stuff noticed: > drivers/pci/controller/plda/pcie-plda-host.c:114:36: warning: unused variable 'plda_evt_dom_ops' [-Wunused-const-variable] > drivers/pci/controller/plda/pcie-plda-host.c:118:36: warning: unused variable 'plda_event_ops' [-Wunused-const-variable] Details like this *are* important because fixing them makes the individual patches more readable, thanks for noticing! Bjorn