On Wed, Sep 13, 2023 at 06:23:31PM +0900, Yoshinori Sato wrote:
> This file move from SH specific directory "arch/sh/drivers/pci/pci-sh7751.h"
>
> Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/pci/controller/pci-sh7751.h | 270 ++++++++++++++++++++++++++++
> 1 file changed, 270 insertions(+)
> create mode 100644 drivers/pci/controller/pci-sh7751.h
If this is a move from arch/sh/drivers/pci/, shouldn't this diff show
both the removal and the addition? Or even better, if you use "git
mv", won't it show the move directly, without a diff at all?
This file is only used in one place, so please just incorporate it
directly into pci-sh7751.c. I think the git history would be a little
cleaner if you did this as a separate patch before moving it to
drivers/pci/.
If you're moving things into drivers/pci/, follow the subject line
conventions (see "git log --oneline drivers/pci/controller/"):
- No period at end of subject line
- Subject line begins with "PCI: <driver-tag>: <Verb> ...", e.g.,
PCI: sh7751: Add SH7751 driver
> diff --git a/drivers/pci/controller/pci-sh7751.h b/drivers/pci/controller/pci-sh7751.h
> new file mode 100644
> index 000000000000..9b7de8243e92
> --- /dev/null
> +++ b/drivers/pci/controller/pci-sh7751.h
> @@ -0,0 +1,270 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Low-Level PCI Support for SH7751 targets
> + *
> + * Dustin McIntire (dustin@xxxxxxxxxxxx) (c) 2001
> + * Paul Mundt (lethal@xxxxxxxxxxxx) (c) 2003
> + *
> + * May be copied or modified under the terms of the GNU General Public
> + * License. See linux/COPYING for more information.
Unnecessary text, given the SPDX header above.
> + *
Spurious blank line.
> +/* Platform Specific Values */
> +#define SH7751_VENDOR_ID 0x1054
> +#define SH7751_DEVICE_ID 0x3505
> +#define SH7751R_DEVICE_ID 0x350e
Most of this file uses upper-case hex, so use it consistently.
Bjorn
