On Sun, Sep 17, 2023 at 04:40:15PM -0500, Bjorn Helgaas wrote: > On Sat, Sep 16, 2023 at 03:36:50PM +0200, Lukas Wunner wrote: > > The "pcie_find_root_port(child) != pdev" check is always false: > > If we were using pci_walk_bus() and only looking at devices below > pdev, I would agree, but since we're using pci_get_class(), which > searches all PCI devices in the system, I'm confused about why it > would always be false. Right, I had misread the patch, I indeed thought it was using pci_walk_bus(). My apologies for the noise. (I guess I assumed that because a global search (as done here) is more expensive than just searching below the Root Port.) Thanks, Lukas