Re: [PATCH] PCI: of: Fix memory leak when of_changeset_create_node() failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 9/15/23 00:04, Herve Codina wrote:
Hi Lizhi

On Thu, 14 Sep 2023 11:15:51 -0700
Lizhi Hou <lizhi.hou@xxxxxxx> wrote:

Destroy and free cset when failure happens.

Fixes: 407d1a51921e ("PCI: Create device tree node for bridge")
Reported-by: Herve Codina <herve.codina@xxxxxxxxxxx>
Signed-off-by: Lizhi Hou <lizhi.hou@xxxxxxx>
  drivers/pci/of.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 2af64bcb7da3..67bbfa2fca59 100644
Why this patch alone ?
The issue fixed by this patch is related to the patch 2 in a series under review
Is the patch 2 in this series already applied by some maintainers ?

You have to fix the patch in the series sending a new iteration of the series.

This patch alone does not make sense.

Otherwise, the modifications to fix the issue seem good.


--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -663,7 +663,6 @@ void of_pci_make_dev_node(struct pci_dev *pdev)
  	np = of_changeset_create_node(cset, ppnode, name);
  	if (!np)
  		goto failed;
-	np->data = cset;
ret = of_pci_add_properties(pdev, cset, np);
  	if (ret)
@@ -673,12 +672,17 @@ void of_pci_make_dev_node(struct pci_dev *pdev)
  	if (ret)
  		goto failed;
+ np->data = cset;
  	pdev->dev.of_node = np;
return; failed:
+	if (cset) {
+		of_changeset_destroy(cset);
+		kfree(cset);
+	}
  	if (np)

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux