On Fri, Sep 08, 2023 at 09:15:09AM +0000, D M, Sharath Kumar wrote: > > -----Original Message----- > > From: Bjorn Helgaas <helgaas@xxxxxxxxxx> > > > +static u32 port_conf_off; > > > > port_conf_off looks like something that should be per-controller. > Specific to agilex, will rename to "aglx_port_conf_off" This comment was not about the *name*, it was about the fact that it's a single instance that applies to *all* controllers. It might be the case that current hardware only supports a single controller, or that if you have multiple controllers they all use the same port_conf_off value, but for generality, values like this would normally be in the per-controller structure. Bjorn
