Re: [EXTERNAL] Re: [RFC PATCH 2/2] PCI: j721e: Add support to build pci-j721e as a kernel module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 8/17/2023 10:34 PM, Bjorn Helgaas wrote:
On Thu, Aug 17, 2023 at 05:38:23PM +0530, Achal Verma wrote:
pci-j721e driver can be build as a in-built kernel driver only, which is
not required as it is not used during boot time in most cases.
This change add support to build pci-j721e as a kernel loadable module.

J721e PCIe controller can work in both host mode and end-point mode.
In order to enable host mode driver and endpoint driver to be built
independently either as built-in or kernel module, the pcie-j721e.c driver
is refactored into following components:

1) pci-j721e-host.c: Driver used when PCIe controller has to be
initialized in host mode.

2) pci-j721e-ep.c: Driver used when PCIe controller has to be
initialized in endpoint mode.

3) pci-j721e.c: contains common code required in both modes.

Sounds like at least two commits (I'm not sure what the best order
would be):

   1) Split into separate host mode and endpoint mode drivers

   2) Make both drivers tristate

So one patch for .c files and Makefile and other one for Kconfig.

It looks like you implement both module loading and removal.  Do we
now think removal of these modules is safe?  IIRC there used to be a
question related to irq_desc lifetimes, e.g., there's some discussion

The ability to *load* drivers as modules is definitely useful.  The
ability to *remove* them is useful for developers but not really
useful for users.

But I guess j721e_pcie_remove() already exists, so maybe you're not
changing anything as far as irq_desc lifetimes
I went through the email-thread you have shared.
It looks like its related to the issue when pcie bridge driver also working as a interrupt domain/controller for EP. In case of legacy interrupt support, its required that pcie host driver free interrupt mapping before freeing the interrupt domain.

Note that current upstream implementation of pci-j721e doesn't support interrupt domain, so issue doesn't applies here but its there in TI kernel and I believe we are handling this in proper way by freeing the mappings before.

Also pci-j721e remove() was lacking some important clean-up functions including pci_remove_root_bus() without which remove wasn't possible, so added required calls and checked the correct sequence of calls.

I have tested load/un-load multiple times on J784S4 EVM PCIe1 instance, it worked fine but reload after load->un-load in case of j721e fails leading to kernel hung, I suspect this as something to do with improper (sequence) handling of refclk for endpoint (shutting down and then powering up) as the only difference between these is that for J784S4 both host controller and EP side use shared ref-clk generated by pcie phy while in j721e case host controller use pcie-phy clock while EP side uses board generated ref-clock, so something to do with power and clock off/on sequence.

Since you're splitting into new files, maybe this is an opportunity to
fix my naming mistake of suggesting a "pci-" prefix instead of


  config PCI_J721E_HOST
-	bool "TI J721E PCIe controller (host mode)"
+	tristate "TI J721E PCIe controller (host mode)"
  	depends on OF
  	select PCI_J721E
@@ -56,7 +56,7 @@ config PCI_J721E_HOST
config PCI_J721E_EP
-	bool "TI J721E PCIe controller (endpoint mode)"
+	tristate "TI J721E PCIe controller (endpoint mode)"
  	depends on OF
  	depends on PCI_ENDPOINT

+static struct platform_driver j721e_pcie_ep_driver = {
+	.probe  = j721e_pcie_probe,
+	.remove_new = j721e_pcie_remove,
+	.driver = {
+		.name	= "j721e-pcie-ep",
+		.of_match_table = of_j721e_pcie_ep_match,
+		.suppress_bind_attrs = true,
+	},

+static struct platform_driver j721e_pcie_host_driver = {
+	.probe  = j721e_pcie_probe,
+	.remove_new = j721e_pcie_remove,
+	.driver = {
+		.name	= "j721e-pcie-host",
+		.of_match_table = of_j721e_pcie_host_match,
+		.suppress_bind_attrs = true,
+	},

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux