On Tue, 22 Aug 2023, Rafael J. Wysocki wrote: > On Tue, Aug 22, 2023 at 3:24 PM Ilpo Järvinen > <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > > > > On Tue, 22 Aug 2023, Feiyang Chen wrote: > > > > > When the current state is already PCI_D0, pci_power_up() will return > > > 0 even though dev->pm_cap is not set. In that case, we should not > > > read the PCI_PM_CTRL register in pci_set_full_power_state(). > > > > IMHO, this is a bit misleading because after this patch, pci_power_up() > > returns always an error if dev->pm_cap is not set. > > Yes, it does, but it has 2 callers only and the other one ignores the > return value, so this only matters here. I did only mean that the changelog could be more clear how it achieves the desired result (as currently it states opposite of what the code does w.r.t. that return value). I'm not against the approach taken by patch. -- i.
