On Fri, 18 Aug 2023, 黄少波 wrote: You should add () to the function name in the subject and use capital PCI/MSI. > Whether to support 64-bit address status has been calculated before, > and the calculation result can be used directly afterwards, so use > msi_attrib.is_64 to avoid double calculation. > > Suggested-by: weipengliang <weipengliang@xxxxxxxxxx> > Signed-off-by: sparkhuang <huangshaobo3@xxxxxxxxxx> > --- > drivers/pci/msi/msi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c > index ef1d885..304e889 100644 > --- a/drivers/pci/msi/msi.c > +++ b/drivers/pci/msi/msi.c > @@ -303,7 +303,7 @@ static int msi_setup_msi_desc(struct pci_dev *dev, int nvec, > desc.pci.msi_attrib.multiple = ilog2(__roundup_pow_of_two(nvec)); > desc.affinity = masks; > > - if (control & PCI_MSI_FLAGS_64BIT) > + if (desc.pci.msi_attrib.is_64) > desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64; > else > desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32; > -- > 2.7.4 Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> -- i.
