Re: [PATCH v12 1/9] ACPI: Add comments to clarify some #ifdef statements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 8/16/2023 1:41 PM, Mario Limonciello wrote:
With nested #ifdef statements it's sometimes difficult to tell
which code goes with which statement.  One comment was wrong,
so fix it and add another comment to clarify another.

I would explain what is wrong clearly in the commit log. I see this file has
many #ifdefs without comments. Do you want to fix them all?

Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
v9->v10:
  * no changes
---
  include/linux/acpi.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 641dc48439873..0d5277b7c6323 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -1117,10 +1117,10 @@ static inline void arch_reserve_mem_area(acpi_physical_address addr,
  					  size_t size)
  {
  }
-#endif /* CONFIG_X86 */
+#endif /* CONFIG_IA64 */
  #else
  #define acpi_os_set_prepare_sleep(func, pm1a_ctrl, pm1b_ctrl) do { } while (0)
-#endif
+#endif /* CONFIG_ACPI */
#if defined(CONFIG_ACPI) && defined(CONFIG_PM)
  int acpi_dev_suspend(struct device *dev, bool wakeup);



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux