Hello Pali,
On Tue, Aug 08, 2023 at 09:31:54AM +0200, Pali Rohár wrote:
> On Friday 04 August 2023 12:06:55 Bjorn Helgaas wrote:
> > I queued up the revert below, including a note in the Kconfig help
> > text about the known issues.
> >
> > commit 814b6bb15367 ("Revert "PCI: mvebu: Mark driver as BROKEN"")
> > Author: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Date: Fri Aug 4 11:54:43 2023 -0500
> >
> > Revert "PCI: mvebu: Mark driver as BROKEN"
> >
> > b3574f579ece ("PCI: mvebu: Mark driver as BROKEN") made it impossible to
> > enable the pci-mvebu driver. The driver does have known problems, but as
> > Russell and Uwe reported, it does work in some configurations, so removing
> > it broke some working setups.
> >
> > Revert b3574f579ece so pci-mvebu is available. Mention the known problems
> > in the Kconfig help text.
> >
> > Reported-by: Russell King (Oracle) <linux@xxxxxxxxxxxxxxx>
> > Link: https://lore.kernel.org/r/ZMzicVQEyHyZzBOc@xxxxxxxxxxxxxxxxxxxxx
> > Reported-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20230804134622.pmbymxtzxj2yfhri@xxxxxxxxxxxxxx
> > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >
>
> What you are trying to achieve with this patch now?
We all agree that there are problems with the pci-mvebu driver. But to
my knowledge it works in some configurations. So I guess the thing to
achieve here is to go from "broken for everyone" (with the driver
depending on BROKEN) to "broken for only some people". So in my view
it's an improvement.
> Do you think that it is really correct to show that everything is
> working for everybody correctly?
What makes you think Bjorn considers everything to work fine? Both the
commit log and the added help text suggest he's aware of problems.
> Now I'm starting understand why majority of HW industry say to not use
> "unsupported mainline kernel" and instead use our prepared patched
> kernels...
Yes, for a given company it's the easiest and cheapest option to just
support a single kernel version. In this regard the patch adding the
dependency on BROKEN is even worse than the commit that removes it
again. In an ideal world Marvell would care to work on the issues of
their hardware's drivers or at least provide enough documentation to the
folks who care about these drivers. I guess we both know we're not in
that ideal world.
I wonder what's your objective problem with this revert. You can just
keep PCI_MVEBU disabled, so it doesn't affect the machines you care
about. You might get some mail with complaints that the driver is
broken in some configuration. But without this revert you might get
(more?) complaints that the driver cannot be enabled. Is that any
better?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
