[+cc linux-arm-kernel, beginning of thread: https://lore.kernel.org/r/20230114164125.1298-1-pali@xxxxxxxxxx] On Tue, Aug 08, 2023 at 09:26:05AM +0200, Pali Rohár wrote: > On Friday 04 August 2023 12:35:13 Russell King (Oracle) wrote: > ... > > For example, I have an Atheros PCIe WiFi card in an Armada 388 Clearfog > > platform, and this works fine. > > > > Uwe has a SATA controller for a bunch of disks in an Armada 370 based > > NAS platform that is connected to PCIe, and removing PCIe support > > effectively makes his platform utterly useless. > > > > Please revert this patch. > > Please do not revert it, instead start fixing problems. We know that like all the other drivers, the mvebu driver isn't perfect. But I don't think effectively removing the driver completely helps anybody. If people try to use it and notice problems, we have a chance to try to fix them. Or maybe I'm missing your point. I think you're suggesting that we keep pci-mvebu in the tree but unselectable because it depends on CONFIG_BROKEN. What would be the advantage of doing that? Bjorn