On Fri, Aug 04, 2023 at 12:35:13PM +0100, Russell King (Oracle) wrote: > Hi, > > So it seems this patch got applied, but it wasn't Cc'd to > linux-arm-kernel or anyone else, so those of us with platforms never > had a chance to comment on it. > > *** This change causes a regression to working setups. *** > > It appears that the *only* reason this patch was proposed is to stop a > kernel developer receiving problem reports from a set of users, but > completely ignores that there is another group of users where this works > fine - and thus the addition of this patch causes working setups to > regress. > > Because one is being bothered with problem reports is not a reason to > mark a driver broken - and especially not doing so in a way that those > who may be affected don't get an opportunity to comment on the patch! > Also, there is _zero_ information provided on what the reported problems > actually are, so no one else can guess what these issues are. > > However, given that there are working setups and this change causes > those to regress, it needs to be reverted. > > For example, I have an Atheros PCIe WiFi card in an Armada 388 Clearfog > platform, and this works fine. Further testing - same platform with a mini-PCIe SATA card: 01:00.0 SATA controller: ASMedia Technology Inc. ASM1062 Serial ATA Controller (rev 01) with a WD10JPVX-60JC3T0 2.5" drive with hdparm -t: Timing buffered disk reads: 344 MB in 3.01 seconds = 114.16 MB/sec which is about what is expected for spinny-rust 2.5" drives. This was tested with ASPM and AER disabled. AER isn't supported anyway as pcie_init_service_irqs() fails with -ENODEV. For further info, the Atheros WiFi card was: 02:00.0 Network controller: Qualcomm Atheros QCA986x/988x 802.11ac Wireless Network Adapter -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
