On 03/08/2012 11:50 PM, Thierry Reding wrote: > * Stephen Warren wrote: >> On 03/08/2012 07:51 AM, Thierry Reding wrote: >>> This commit adds support for message signaled interrupts to the Tegra >>> PCIe controller. >>> >>> Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx> >>> --- >>> This code is taken from the NVIDIA Vibrante kernel and therefore has no >>> appropriate Signed-off-by from the original author. Maybe someone at >>> NVIDIA can find out who wrote this code and maybe provide a proper >>> Signed-off-by that I can add? >> >> I think if you look in: >> git://nv-tegra.nvidia.com/linux-2.6.git android-tegra-2.6.36 >> >> the following commits are what you're after: >> >> de7fd8768b32da66eaf4eaf58473c65f7a76808d >> arm: tegra: pcie: enabling MSI support for pcie >> >> ac1f8310811c64a084511d2afc27f66334b31a81 >> ARM: tegra: pcie: fix return value from MSI irq routine >> >> Although the patch below only partially resembles those patches, I guess >> because you've rewritten the code a lot to conform to the current kernel >> APIs, clean stuff up, etc. Perhaps just saying "based on code by Krishna >> Kishore <kthota@xxxxxxxxxx>" is enough... > > Yes, it is indeed a major rewrite because the original code had some > peculiarities and FIXME that I thought wouldn't make it through the review > anyway so I fixed them up. > > I'll add some comment about the original authorship. There is no official > Signed-off-by in the original commit. Do I still need one or is it enough to > mention the original authors in the commit message and add keep my own > Signed-off-by? Yes, I think just mentioning the original code author in free-form text, and including only your S-o-b sounds good to me. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
