Re: [PATCH 1/1] PCI: dwc: Use regular interrupt instead of chained

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Thu, Jun 29, 2023 at 11:04:50PM -0400, Radu Rendec wrote:
> On Thu, 2023-06-29 at 17:11 -0500, Bjorn Helgaas wrote:
> ...

> > If converting from chained to normal handlers can be done safely, I
> > would definitely be in favor if doing it across all of drivers/pci/ at
> > once so they're all consistent.  Otherwise that code just gets copied
> > to new drivers, so the issue persists and spreads.
> I think the conversion can be done safely, meaning that it won't break
> the drivers. And by the way, there are other IRQ drivers (outside the
> PCI space) that use chained interrupts.
> Unfortunately, it seems we are going in circles. Chained interrupts are
> bad because they let IRQ storms go unnoticed and lock up the system,
> but converting them to regular interrupts is also bad because it breaks
> the userspace ABI.
> I am willing to help clean up this mess, but I think first we need to
> come up with a solution that's acceptable for everybody. I was hoping
> Marc and Thomas would chime in, but unfortunately that hasn't happened
> yet - other than each of them pointing out (separately) what is wrong
> with each approach.

I don't think Marc or Thomas are going to chime in with a fully-formed
solution.  I think to make progress, you (or Pali, or somebody) will
have to try to address Marc and Thomas' comments, make a proposal, and
we can iterate on it.


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux