On Tue, Jul 11, 2023 at 02:57:15PM +0200, Amadeusz Sławiński wrote: > Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers. > Almost every use contains additional comments to identify to which > platform those IDs refer to. Add those IDs to pci_ids.h header, so that > there is one place which defines those names. >From style looks good to me, but I think somebody from ASoC/sound needs to carefully check HDA/non-HDA/etc. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> # for the Intel Tangier ID > Acked-by: Mark Brown <broonie@xxxxxxxxxx> > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko