[PATCH] PCI: vmd: VMD to control Hotplug on its rootports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


The hotplug functionality is broken in various combinations of guest
OSes i.e. RHEL, SlES and hypervisors i.e. KVM and ESXI.

VMD enabled on Intel ADL cpus caused interrupt storm for smasung
drives due to AER being enabled on VMD controlled root ports.
The patch 04b12ef163d10e348db664900ae7f611b83c7a0e
("PCI: vmd: Honor APCI _OSC on PCIe features.") was added to the VMD
driver to correct the issue based on the following assumption:
	“Since VMD is an aperture to regular PCIe root ports, honor ACPI
	_OSC to disable PCIe features accordingly to resolve the issue.”
	Link: https://lore.kernel.org/r/20211203031541.1428904-1-kai.heng.feng@xxxxxxxxxxxxx

VMD as a PCIe device is an end point(type 0), not a PCIe aperture
(pcie bridge). In fact VMD is a type 0 raid controller(class code).
When BIOS boots, all root ports under VMD is inaccessible by BIOS, and
as such, they maintain their power on default states. The VMD UEFI DXE
driver loads and configure all devices under VMD. This is how AER,
power management and hotplug gets enabled in UEFI, since the BIOS pci
driver cannot access the root ports.

The patch worked around the interrupt storm by assigning the native
ACPI states to the  root ports under VMD. It assigns AER, hotplug,
PME, etc. These have been restored back to the power on default state
in guest OS, which says the root port hot plug enable is default OFF.
At most, the work around should have only assigned AER state.
An additional patch should be added to exclude hot plug from the
original patch.
This will cause hot plug to start working again in the guest, as the
settings implemented by the UEFI VMD DXE driver will remain in effect
in Linux.

Signed-off-by: Nirmal Patel <nirmal.patel@xxxxxxxxxxxxxxx>
 drivers/pci/controller/vmd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 769eedeb8802..52c2461b4761 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -701,8 +701,6 @@ static int vmd_alloc_irqs(struct vmd_dev *vmd)
 static void vmd_copy_host_bridge_flags(struct pci_host_bridge *root_bridge,
 				       struct pci_host_bridge *vmd_bridge)
-	vmd_bridge->native_pcie_hotplug = root_bridge->native_pcie_hotplug;
-	vmd_bridge->native_shpc_hotplug = root_bridge->native_shpc_hotplug;
 	vmd_bridge->native_aer = root_bridge->native_aer;
 	vmd_bridge->native_pme = root_bridge->native_pme;
 	vmd_bridge->native_ltr = root_bridge->native_ltr;

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux