On Wed, Jun 28, 2023 at 10:51:27PM +0200, Amadeusz Sławiński wrote: > PCI IDs for Intel HDA are duplicated across quite a few drivers, due to > various configurations and historical reasons. Currently almost all uses > of HDA PCI IDs have corresponding comment telling which platform it is. > Additionally there are some inconsistencies between drivers about which > ID corresponds to which device. > > Simplify things, by adding PCI IDs to global header and make use of them > in drivers. This allows for removal of comments by having IDs themselves > being self explanatory. Additionally it allows for removal of existing > inconsistencies by having one source of truth. I'm in favour of this series. It allows to use PCI_DEVICE_DATA() in many places. With that said, I think you can also add some more definitions to PCI IDs header for the sake of being able to use that macro. -- With Best Regards, Andy Shevchenko
